Bastion of Glory

The definition of "Raid buff" is assigned to any friendly buff or aura that is assumed to be present in a serious raid environment.

In this case, we are specifically talking of the 10% atk speed aura provided by Frost/Unholy DKs, Enhancement Shamans, Rogues of any spec and certain hunter pets (Serpents if my memory doesn't fail me).

Adeya wrote:

Also, the raid buff certainly wouldn't reduce your melee haste from 23.39% to 17.52%!

Frankly, I thought that outcome was suspect. Nonetheless, I dont' see an error in my derivation of the formula from the calculation of Spell Haste that you provided previously. The numbers are simply substituted for the variables in the formula. If the outcome of a calculation is wrong, then the formula must be wrong, so what is the error in the formula? (Assuming that I pressed the right buttons on the calculator, of course.)

The error isn't in the formula, it's in the substitution. You plugged in R=1.05, which means you're assuming the 5% spell haste raid buff is active. However, it wasn't active when you took your data. You actually had M=1.2339, I=1.10, and R=1.0. Multiplying those together tives you the 1.3573 that you started with for S.

Adeya wrote:Then again, I have no idea what "the raid buff" does or doesn't do. For that matter, I don't recall any mention of a "raid buff" in the spellbook or in any other part of the game sofware. So far I have never found any documentation for it. How do you know that such a thing actually exists?

This post summarizes the eight major raid buffs, along with which classes/specs provide them. The "5% Spell Haste" raid buff is the one that's relevant to this conversation.

Unfortunately: haste = GetMeleeHaste() is returning 59.2070... while the paladin is attacking a target dummy without any trinket procs or other buffs of any kind, but Melee Haste on the paper doll is +32.04% with Haste 13,619.

theckhd wrote:

Adeya wrote:

Also, the raid buff certainly wouldn't reduce your melee haste from 23.39% to 17.52%!

Frankly, I thought that outcome was suspect. Nonetheless, I dont' see an error in my derivation of the formula from the calculation of Spell Haste that you provided previously. The numbers are simply substituted for the variables in the formula. ....

The error isn't in the formula, it's in the substitution. You plugged in R=1.05, which means you're assuming the 5% spell haste raid buff is active. However, it wasn't active when you took your data. You actually had M=1.2339, I=1.10, and R=1.0. Multiplying those together tives you the 1.3573 that you started with for S.

Ah ... thanks for the clarification! It looks as though I must calculate the value of Melee Haste from the value of Spell Haste after all. So I must find out whether the raid buff that grants +5% to Haste is active, and whether the Seal of Insight is active, too.

theckhd wrote:

Adeya wrote:Then again, I have no idea what "the raid buff" does or doesn't do. For that matter, I don't recall any mention of a "raid buff" in the spellbook or in any other part of the game sofware. So far I have never found any documentation for it. How do you know that such a thing actually exists?

This post summarizes the eight major raid buffs, along with which classes/specs provide them. The "5% Spell Haste" raid buff is the one that's relevant to this conversation.

That's what I supposed to be the case, but I wanted to be sure that you weren't referring to some other "raid buff" buried in the combat system somewhere.

Adeya wrote:Unfortunately: haste = GetMeleeHaste() is returning 59.2070... while the paladin is attacking a target dummy without any trinket procs or other buffs of any kind, but Melee Haste on the paper doll is +32.04% with Haste 13,619.

Are you sure? While standing in town, a quick "/script print(GetMeleeHaste())" in chat gives me 48.080001831055, which is consistent with the 48.08% haste on my character sheet (alone, so the 10% attack speed buff that incorrectly shows up as haste on character sheet is not active).

theckhd wrote:

Adeya wrote:Unfortunately: haste = GetMeleeHaste() is returning 59.2070... while the paladin is attacking a target dummy without any trinket procs or other buffs of any kind, but Melee Haste on the paper doll is +32.04% with Haste 13,619.

Are you sure? While standing in town, a quick "/script print(GetMeleeHaste())" in chat gives me 48.080001831055, which is consistent with the 48.08% haste on my character sheet (alone, so the 10% attack speed buff that incorrectly shows up as haste on character sheet is not active).

That is what was returned when I used the API function in the addon that I've been upgrading -- the line of code is exactly as written in the addon. The line beneath it was a normal print() command to send the output to the General tab of the chat window. I could not find any error in it later.

Now: running your script via the chat /command line produces the number 32.0352935102% (which is both his Melee Haste and Spell Haste on the paper doll without any buffs. ATM, the paladin is in Retribution spec without any buffs except the Gaze of the Black Prince.

Using a macro: /run haste = GetMeleeHaste(); print(haste) produces the same number.

So it appears to be working. Since the paladin's Melee Haste and Spell Haste are the same ATM there is no way to verify whether it is the Melee Haste which is returned, but no reason to doubt it, either.

I must try it again in the addon. It doesn't make any sense to be working correctly in the macro and on the /command line but not in CLCProt. There's no reason that I can think of for the number to be anything but the one that is being reported now.

Say, would the buff from Tajing the Cyclone have anything to do with this? It does increase the paladin's speed considerably!! ......

If I find out, then I'll let you know. :-)

Just activate Seal of Insight, if you want to make sure that it's melee haste and not spell haste.

Adeya wrote: .... I must try it again in the addon. It doesn't make any sense to be working correctly in the macro and on the /command line but not in CLCProt. There's no reason that I can think of for the number to be anything but the one that is being reported now.

Say, would the buff from Tajing the Cyclone have anything to do with this? It does increase the paladin's speed considerably!! ......

If I find out, then I'll let you know. :-)

UPDATE: Since I suspected the buff which Tajing the Cyclone at Shrine of the 7 Stars bestows, I took the portal to the Exodar. I've done that many times when testing the addon and investigating how things work in WoW combat. There are very few other players around, none to challenge me to a duel, or to bestow buffs on my paladin uninvited. Of course, Tajing's buff had nothing to do with it.

What was happening with Melee Haste: it would be at the expected value of 32.04% for a while, then increase for a few seconds to 35.xxx, then return to 32.04%, then suddenly shoot-up to 79.xx% and seemed to last forever when you're looking at scrolling ouput on the General Tab of the chat window at 10 lines per second. Sometimes it might even go higher before falling back to 79.xx%.

Eventually I discovered that this was caused by a proc from the Alacrity of Xuen (trinket), which has a 15% chance of adding 11,544 Haste for 20 sec. (115 sec. cooldown). Since I acquired it at least 6 months ago, I've seen it on the buff bar many times during combat -- quite rarely when fighting a target dummy -- although it is so infrequent that it is easy to overlook. But I don't recall seeing it on the buff bar while investigating why the API function GetMeleeHaste() was returning such a large percentage. Since nothing else was displaying anything there (other than the guild tabard and The Gaze of the Black Prince), it should have been obvious. What tipped me, though, was the paladin pointing a finger briefly overhead and a fishnet pattern of "electricity" appearing across his back, accompanied by an odd sound -- and the increase in the value of Melee Haste in that context. When I recognized the association of these events, I knew it had to be a proc ... probably a random trinket proc.

This is what comes of having a piece equipped for so long that you forget what affect it has on your game. So it appears that the API function GetMeleeHaste() does what it is supposed to do.

In the process, though, I discovered an anomaly pertaining to the Global Cooldown that I cannot understand, but I will post an OP on another topic if I decide to seek your aid and advice.

Thels wrote:Just activate Seal of Insight, if you want to make sure that it's melee haste and not spell haste.

(deleted) this editor needs a strike-through font (deleted) Okay, activating the Seal of Insight increased Spell Haste, the value of which was returned as a percentage by another API function UnitSpellHaste("player"). Other than verifying that, I de-activated the Seal of Insight to remove any possibility of it affecting the value returned by GetMeleeHaste(). Not that I expected Seal of Insight to have any effect on Melee Haste, but you never know whether the code for any feature has a bug unless and until you find one. So one way to investigate is to remove all the possible sources, then add them back, one-by-one.

Soon the paladin was equipped only with a shirt, a guild tabard, a one-handed sword, and a shield -- none of which had any Haste on them. :-) The only buffs and other affects upon his abilities were from passive spells and the Seal (when activated), or from using an ability such as Guardian of Ancient Kings or Avenging Wrath. I also changed the Tier 5 talent from Divine Protection to Sanctified Wrath, just to eliminate the random proc, although, as with the Seal of Insight, it doesn't have any known effect upon Haste.

I merely advised activating Seal of Insight, since you mentioned that you still weren't fully sure if you were getting Melee Haste or Spell Haste. Popping Seal of Insight and checking if the value changes would've quickly answered that. :)