For those bothered by ShoR's lack of a sound effect...

Harlequina wrote:

notforbiting wrote:@ harlequina, you have to completely restart wow after placing the wav file in the addons folder; it wont play otherwise. if you've done that, make sure you have thatjusthappened set up correctly, i believe theres a checkbox somewhere you have to check to enable it.

http://img181.imageshack.us/my.php?image=tjh5vp4.jpg








The problem is that there simply is no sound playing. I tried with the "CleaveTarget.wav" that you used in the first rule you posted. In other words, a sound in the MPQ files, but it doesn't work either.

I can't see why it wouldn't work for me, if it actually works for you this way. Restarting the game changed nothing.

well, from your screenshot this is the only tjh rule you have set up, so i'm assuming this is your first time using the addon.. try doing /tjh on and see if it works then..

You were right. But damn, that was stupid. I am stupid, but the addon is also stupid. It should be goddamn enabled at start. There was a button for it in the interface, but hey, when it's "disabled" the button is almost greyed out! Or the text on it anyhow.


So for all new users of TJH, remember to do a "/tjh on"



But yea I was stupid. IT FRIGGIN' WORKS NOW! SHIELD SLAMMMMMMMMMMMMMMMMMMMMMMMMMMMMMMM!

Thanks for the help.

/script PlaySoundFile("Sound\\Spells\\PolyMorphCow.wav") imo

Bump for the warrior shield slam sound, I've played every single sound I thought it could be an no luck. Closest is the cleave already posted and /script PlaySoundFile("Sound\\Spells\\KnockDown.wav")

The shield slam has been found and applied to tjh but i still dont understand notforbiting you say the change you made to the thatjusthappened.lua could you post a screenshot of what you changed? I cannot find it out : < Perhaps if anyone else could help out also that'd be a great help.

For all those on the EU side still believing in the suggestions forum: thread is at http://forums.wow-europe.com/thread.html?topicId=6915172295&sid=1

stillman wrote:The shield slam has been found and applied to tjh but i still dont understand notforbiting you say the change you made to the thatjusthappened.lua could you post a screenshot of what you changed? I cannot find it out : < Perhaps if anyone else could help out also that'd be a great help.

here is the change you must make to thatjusthappened.lua

open ThatJustHappened.lua and head on down to line 701 or search for

Code: Select all

SendChatMessage(msg, "CHANNEL", nil, GetChannelName(channel));

and after that line, ADD:

Code: Select all

   elseif channel == "PLAYSOUND" then
         PlaySoundFile(msg);

save and exit.

If one does not want to install TJH, try this:

Create a folder in your addon directory, name it "SoundShoR" or what ever you like.
In there, create a new textfile and name it Core.lua (without the .txt), open it with notepad, copy and paste:

Code: Select all

local playerGUID
local function onPlayerEnteringWorld()
   playerGUID = UnitGUID("player")
end

local SPELL_CAST_SUCCESS = "SPELL_CAST_SUCCESS"
local function onCombatLogEvent(_, _, _, event, sourceGUID, _, _, _, _, _, spellId, _, _)
   if (sourceGUID == playerGUID) and (event == SPELL_CAST_SUCCESS) and ((spellId == 53600) or (spellId == 61411)) then
      PlaySoundFile(YOUR SOUND FILE HERE)
   end
end

local eventFrame = CreateFrame("Frame")
eventFrame:SetScript("OnEvent",
   function(eventFrame, event, ...)
      eventFrame[event](eventFrame, event, ...)
   end)

eventFrame.PLAYER_ENTERING_WORLD = onPlayerEnteringWorld
eventFrame:RegisterEvent("PLAYER_ENTERING_WORLD")

eventFrame.COMBAT_LOG_EVENT_UNFILTERED = onCombatLogEvent
eventFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")


Create a second textfile, name it "SoundShoR.toc" or the name you gave the folder with .toc as suffix.
Copy and paste:

Code: Select all

## Interface: 30000
## Title: YOUR TITEL HERE (Name of the folder)
## Notes: YOUR NOTE HERE
## Author: Maethoriel
## Version: 1.0.0

Core.lua


You have to replace YOUR SOUND FILE HERE with the path to what ever sound you want to hear.
Example:
PlaySoundFile("Sound\\Spells\\ShieldWallTarget.wav")

Still haven't found one that i like tough :\

The sound isn't playing all of a sudden for me (using TJH) and I can't work out why. I haven't updated it since I changed the lua file, the rule is still there, and TJH is still enabled and turned on.

All I know is that it was working fine yesterday but not today.

Edit: never mind, restarting wow fixed it for some strange reason. One thing I have noticed though is that the sound will still play even if audio is disabled - is there any way to fix this?

mai macro:

Code: Select all

/castsequence Shield of Righteousness, Hammer of the Righteous
/castsequence [equipped:One-Hand] Shield of Righteousness, Divine Storm, Crusader Strike
/castsequence [equipped:Two-Hand] Crusader Strike, Divine Storm

Ok so how do I get it in there?

You can slamm /run PlaySoundFile(PATH_TO_A_SOUNDFILE) below these 3 lines and it would play everytime you press the macro.
If you want to have it only play with ShoR and only if the spell actually succeeded ... well, you can't with a macro.

Maethoriel wrote:If one does not want to install TJH, try this:

Create a folder in your addon directory, name it "SoundShoR" or what ever you like.
In there, create a new textfile and name it Core.lua (without the .txt), open it with notepad, copy and paste:

Code: Select all

local playerGUID
local function onPlayerEnteringWorld()
   playerGUID = UnitGUID("player")
end

local SPELL_CAST_SUCCESS = "SPELL_CAST_SUCCESS"
local function onCombatLogEvent(_, _, _, event, sourceGUID, _, _, _, _, _, spellId, _, _)
   if (sourceGUID == playerGUID) and (event == SPELL_CAST_SUCCESS) and ((spellId == 53600) or (spellId == 61411)) then
      PlaySoundFile(YOUR SOUND FILE HERE)
   end
end

local eventFrame = CreateFrame("Frame")
eventFrame:SetScript("OnEvent",
   function(eventFrame, event, ...)
      eventFrame[event](eventFrame, event, ...)
   end)

eventFrame.PLAYER_ENTERING_WORLD = onPlayerEnteringWorld
eventFrame:RegisterEvent("PLAYER_ENTERING_WORLD")

eventFrame.COMBAT_LOG_EVENT_UNFILTERED = onCombatLogEvent
eventFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")


Create a second textfile, name it "SoundShoR.toc" or the name you gave the folder with .toc as suffix.
Copy and paste:

Code: Select all

## Interface: 30000
## Title: YOUR TITEL HERE (Name of the folder)
## Notes: YOUR NOTE HERE
## Author: Maethoriel
## Version: 1.0.0

Core.lua


You have to replace YOUR SOUND FILE HERE with the path to what ever sound you want to hear.
Example:
PlaySoundFile("Sound\\Spells\\ShieldWallTarget.wav")

Still haven't found one that i like tough :\

The "LevelUp" sound is not bad, but a bit to loud.

FYI if you spam your hotkey waiting for ShoR to come off of cooldown this will scare the crap out of you mid-raid if you pick a loud sound effect and forget you changed the button to a macro

Maethoriel wrote:If one does not want to install TJH, try this:



Create a folder in your addon directory, name it "SoundShoR" or what ever you like.

In there, create a new textfile and name it Core.lua (without the .txt), open it with notepad, copy and paste:

when i do this, the addon is then made but in the game it does nothing... I check the addon list and it says incompatible... here is what i have

core.lua

Code: Select all

    local playerGUID
    local function onPlayerEnteringWorld()
       playerGUID = UnitGUID("player")
    end

    local SPELL_CAST_SUCCESS = "SPELL_CAST_SUCCESS"
    local function onCombatLogEvent(_, _, _, event, sourceGUID, _, _, _, _, _, spellId, _, _)
       if (sourceGUID == playerGUID) and (event == SPELL_CAST_SUCCESS) and ((spellId == 53600) or (spellId == 61411)) then
          PlaySoundFile("Sound\\Spells\\LevelUp.wav")
       end
    end

    local eventFrame = CreateFrame("Frame")
    eventFrame:SetScript("OnEvent",
       function(eventFrame, event, ...)
          eventFrame[event](eventFrame, event, ...)
       end)

    eventFrame.PLAYER_ENTERING_WORLD = onPlayerEnteringWorld
    eventFrame:RegisterEvent("PLAYER_ENTERING_WORLD")

    eventFrame.COMBAT_LOG_EVENT_UNFILTERED = onCombatLogEvent
    eventFrame:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")

toc

Code: Select all

    ## Interface: 30000
    ## Title: soundShoR
    ## Notes: plays a leveling sound when ShoR is used
    ## Author: Maethoriel
    ## Version: 1.0.0

    Core.lua

have i botched something?